search

jquery / jquery-mousewheel

A jQuery plugin that adds cross-browser mouse wheel support.
Other
3.9k stars 1.69k forks source link

Fix non-passive event listeners issue and add a updated version number #215

Open summercms opened 3 years ago

summercms commented 3 years ago

Relates to (my old account) issue found here: https://github.com/jquery/jquery-mousewheel/issues/202

Have tested this and works fine.

ghost commented 3 years ago

@mgol another one to review after #127

ghost commented 3 years ago

Could it be put behind a compatibility layer for non-IE?

mgol commented 3 years ago

Yes, it could, but it'd still be adding lots of bytes just to silence browser warnings without any actual change in behavior. If we were doing that for jQuery as well it'd make sense but I'm not sure about doing it just in this plugin, diverging from the upstream.

ghost commented 3 years ago

Okay, so the ideal thing to do is icebox this and have passive event listeners adopted in JQ core?

mgol commented 3 years ago

Yes, I think that’s the best option here.-- Michał Gołębiowski-Owczarek

summercms commented 2 years ago

@mgol Internet Explorer 11 desktop application will be retired and go out of support on June 15, 2022. Therefore this repo shouldn't continue to support ie11 after end of life date reached.

Link: https://blogs.windows.com/windowsexperience/2021/05/19/the-future-of-internet-explorer-on-windows-10-is-in-microsoft-edge/

mgol commented 2 years ago

This project will most likely keep following the browser support policy of jQuery and there are no plans to drop IE 11 support there yet.