search

jquery / jquery-ui

The official jQuery user interface library.
https://jqueryui.com
Other
11.25k stars 5.33k forks source link

1.14 needs `$.uiBackCompat = true;` to use `transfer` Effect #2278

Open melloware opened 1 month ago

melloware commented 1 month ago

To use the Transfer effect you have to have $.uiBackCompat = true; and not sure why.

You can see the error on the showcase: https://jqueryui.com/effect/

Pick Transfer and run.

image

mgol commented 1 month ago

Thanks for the report. See https://api.jqueryui.com/transfer-effect/:

This effect is deprecated, replaced by the .transfer() method.

Trac bug #14749 has more details:

The transfer effect doesn't behave like a normal effect. As such, it should be converted a plugin instead of using the effects API.

We should just remove the effect from the demo, I think: https://github.com/jquery/jquery-ui/blob/54f96eea31b21d9ecb00912261df3e5aaebf8cce/demos/effect/default.html#L78

And perhaps also its visual test: https://github.com/jquery/jquery-ui/blob/54f96eea31b21d9ecb00912261df3e5aaebf8cce/tests/visual/effects/effects.js#L86-L92

melloware commented 1 month ago

Thanks you i have updated to use .transfer() method!

mgol commented 4 days ago

PR: #2291