search

jquery / jquery-wp-content

WordPress themes and plugins for the jQuery sites
GNU General Public License v2.0
253 stars 169 forks source link

Add Code of Conduct page sidebar/templates #367

Closed gnarf closed 9 years ago

gnarf commented 9 years ago

I'm pretty sure something is wrong with the way that I'm doing this.

I just want a sidebar menu with a CC by note

cc @ajpiano or someone can you help look into why the content is behaving weirdly in responsive ways?

I get this when I stretch smaller:

screenshot 2015-07-12 20 41 58

Ref https://github.com/jquery/jquery.org/issues/104

kborchers commented 9 years ago

I would recommend closing this and just having the CoC content depend on https://github.com/kborchers/jquery-wp-content/commit/8fa37c898cbadc2df5f72b1256c04d8738782947 being merged which @agcolom and I will get done ASAP

gnarf commented 9 years ago

How about we keep this open, and once you land that branch, we can update this for it's own get_sidebar function... I really want to have the little menu on the right as the CoC has a bunch of stuff:

Desired output is something like this:

screenshot 2015-07-13 18 18 03

This branch is on the jquery repo so please feel free to update this stuff yourselves as you're working on it @agcolom @kborchers

agcolom commented 9 years ago

@gnarf is there a particular reason to have the menu on the right hand-side as opposed to the left hand-side? (other sites have the menu of the left, e.g meetings, brand, etc).

gnarf commented 9 years ago

I thought it felt better on the right, but on the left works for me too if it fixes the problem :)

agcolom commented 9 years ago

Yes, I'm concerned about consistency... especially after seeing the talks on accessibility at jQSF. Any other thoughts from @arthurvr @AurelioDeRosa @ajpiano ?

arthurvr commented 9 years ago

Let's be consistent. I don't really think it looks better at the right, too.

gnarf commented 9 years ago

Could one of you update it to be on the left then? I'm going to be really busy today as I'm getting on a flight to Austin tomorrow and trying to finish up a lot of in-flight stuffs... I don't mind - feel free to fix the other stuffs too :)

agcolom commented 9 years ago

@gnarf sure :-)

agcolom commented 9 years ago

@gnarf @arthurvr Ok, so Arthur and I had a chat about this and tried a few things. I think we've got all the info we need to move the menu to the left and update the content with the provided feedback. I'll be able to do that first thing in the morning tomorrow, unless I get a chance this evening...

gnarf commented 9 years ago

Looks good, I'll land this right before landing the conduct content branch.