search

jquery / jquery-wp-content

WordPress themes and plugins for the jQuery sites
GNU General Public License v2.0
253 stars 169 forks source link

jquerymobile.com: Add books to footer #372

Closed kborchers closed 3 years ago

kborchers commented 9 years ago

@arschmitz Can you please review and merge if you are happy with this?

kborchers commented 9 years ago

Can someone from @jquery/mobile and/or @jquery/content review and merge this so they stop bothering me? I just want another set of eyes to ok it before changing the template for this site.

jaspermdegroot commented 9 years ago

@kborchers

I just reviewed and everything looks good. I don't have write access to this repo so I can't merge for you.

Because I am sure other authors that have their book listed on our Resources page are going to ask us how to get their book in the footer ... is this part of a sponsorship deal?

kborchers commented 9 years ago

There is no specific sponsorship deal but we do get royalties on jQuery related books. They sent me these new books and I just noticed that there were no books in the footer of this site. We can just add them to the resources page if that works better for this site though they are not all mobile related.

arschmitz commented 9 years ago

I think i like the idea of having some in the footer for consistency with other sites. I am thinking we should just do the 3 newest ones in the footer. If any one asks how to get in the footer there is a simple answer. It also makes sense to feature the 3 most up to date books i think.

arthurvr commented 9 years ago

I am thinking we should just do the 3 newest ones in the footer. If any one asks how to get in the footer there is a simple answer. It also makes sense to feature the 3 most up to date books i think.

Yeah, I agree. In fact it would be even better if we could actually review the books and choose the best one, not the newest one, but I guess that's not possible.

arschmitz commented 9 years ago

@arthurvr "best" is always going to be a judgement call and its the kind of judgement i don't think we want to get into. We don't want to alienate authors. We are not book critics and as a foundation or a project i don't think we want to be. These are all published books /authors. I think its fair to assume they are all good.

kborchers commented 9 years ago

Agree 100% with @arschmitz

jaspermdegroot commented 9 years ago

Although it would be nice to have the latest books in the footer, it would mean that we have to do two PRs for each book that we add and I also think no one on the Mobile team has the rights to merge the PR in the jquery-wp-content repo. So I think it's better if we use more static content for templates that are in this repo.

Update: forget that part about no one on the Mobile team having rights in this repo

arschmitz commented 9 years ago

@jaspermdegroot Both @agcolom , myself and the content team all have access and any one on the mobile team can do a PR I don't think this is an issue.

scottgonzalez commented 9 years ago

Although it would be nice to have the latest books in the footer, it would mean that we have to do two PRs for each book that we add

Or we can just automate it from some structured data so that adding a new book is just a matter of adding another item to an array.

arthurvr commented 9 years ago

Or we can just automate it from some structured data so that adding a new book is just a matter of adding another item to an array.

:+1:

imtumbleweed commented 7 years ago

Would anyone be interested adding jQuery Gems (Amazon) to refresh the footer? Please contact me.