search

jquery / jquery-wp-content

WordPress themes and plugins for the jQuery sites
GNU General Public License v2.0
253 stars 169 forks source link

modernize sunrise - replace wpmu_current_site #378

Closed Ipstenu closed 8 years ago

Ipstenu commented 8 years ago

This should fix #303 - resolving the various undefined errors and removing the deprecation warning.

I tested this locally and using your Vagrant setup and it appears to work without throwing errors. I pulled the code from WPMU Domain Mapping ( see https://plugins.trac.wordpress.org/browser/wordpress-mu-domain-mapping/trunk/sunrise.php ) which has to do some odd things since get_current_site doesn't exist when we're calling sunrise.php

Needs more testing in your environment, but I think this may work.

jquerybot commented 8 years ago

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

:memo: Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

gnarf commented 8 years ago

Thanks @Ipstenu - can you go sign the CLA? I'd love to land this! :heart_eyes:

gnarf commented 8 years ago

Just tested this on WP 4.3.1 - still get a "Something went very wrong when trying to install blog.jquery.com as site -2. Find nacin." when trying to install for the first time.

gnarf commented 8 years ago

Thanks so much for looking at this - I merged #379 after testing in 4.3.1. ♥