Closed jeremyfelt closed 8 years ago
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).
:memo: Please visit http://contribute.jquery.org/CLA/ to sign.
After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.
If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.
Just tested, everything looks great - Thanks so much!
Addresses #303:
site_admins
network option may not be properly set during installation locally.downloads.wordpress.org
URLs to survive the protocol relative filter so that local updates will work nicely.This takes a slightly different approach from @Ipstenu in #378 as there are quite a few gotchas hanging out there when running this outside of the Vagrant environment and/or when installing and upgrading.
There's probably room for future improvement, especially once the Vagrant box has been updated to use a newer version of WordPress by default. We could then rewrite a bit more and make a few more assumptions about the environment. This should work as a pretty good stop-gap in the meantime.
I've tested: