Upgrade to jQuery 3 - Githubissues

jquery / jquery-wp-content

WordPress themes and plugins for the jQuery sites

GNU General Public License v2.0

253 stars 169 forks source link

Upgrade to jQuery 3 #400

Closed mgol closed 1 year ago

mgol commented 8 years ago

Currently our sites use jQuery 1.11.3. We should switch to jQuery 3 (eating our own dogfood etc.).

cc @dmethvin @timmywil

Note that this doesn't apply to examples on various API sites which have jQuery copies versioned in repositories specific to those sites.

mgol commented 8 years ago

jQuery is loaded here in the theme: https://github.com/jquery/jquery-wp-content/blob/f9ac577/themes/jquery/header.php#L31

timmywil commented 1 year ago

We'll need to test each site individually, and if any fail in a way that is not trivial to fix, we'll need to parameterize the jQuery version. Here is the comprehensive list:

[x] jquery.com
[x] ~blog.jquery.com~ does not load jquery-wp-content
[x] api.jquery.com
[x] plugins.jquery.com
[x] learn.jquery.com
[x] jqueryui.com
[x] ~blog.jqueryui.com~ does not load jquery-wp-content
[x] api.jqueryui.com
[x] ~jquery.org~ needs redirects to openjsf.org
[x] jquerymobile.com
[x] api.jquerymobile.com
[x] brand.jquery.org
[x] contribute.jquery.org
[x] meetings.jquery.org
[x] releases.jquery.com

mgol commented 1 year ago

jquery.org doesn't fully redirect to openjsf.org. Its home page & some other pages do but e.g. https://jquery.org/team/ is not redirected, the same applies to https://jquery.org/history/.

Although, these pages look quite obsolete. Maybe we should make sure everything gets redirected and kill the site completely.

timmywil commented 1 year ago

Thanks. I didn't notice that, but I agree we can kill the site.

mgol commented 1 year ago

The history site can be quite interesting. It stopped getting updated in 2014 and many links are dead and would have to be rewritten with Web Archive but still.

timmywil commented 1 year ago

I think if we wanted a page like that, we should just redo it static. As it's been broken for a while and not updated, I'd like to redirect and maybe add a history page later.

timmywil commented 1 year ago

All sites pass locally. The pages in demos and examples are loaded in iframes and have their own versions of jquery. I'm fairly confident we don't need to parameterize.

mgol commented 1 year ago

Good to hear!

timmywil commented 1 year ago

I would like to point out that whatever theme the blogs are loading has an even older version of jQuery than jquery-wp-content. That could also be upgraded, but I'd need to be pointed to where those themes are.

timmywil commented 1 year ago

Nevermind, I think I found it https://github.com/jquery/blog.jquery.com-theme

timmywil commented 1 year ago

Opened https://github.com/jquery/blog.jquery.com-theme/pull/6 on the blog theme

timmywil commented 1 year ago

I've run through all the staging sites and they look good to go. The only one I couldn't view was http://stage.jquerymobile.com. It's showing a 500 "Error establishing a database connection".