search

jquery / jquery-wp-content

WordPress themes and plugins for the jQuery sites
GNU General Public License v2.0
253 stars 169 forks source link

All: upgrade relevanssi plugin #441

Closed timmywil closed 1 year ago

timmywil commented 1 year ago

I hit an error when attempting to run grunt deploy on some sites. WPLANG wasn't always defined. Fortunately, the error was fixed upstream.

I've upgraded the plugin to it's latest 3.x version. 4.x may work fine, but I didn't want to deal with breaking changes just yet. It does note a requirement of PHP 5.6, but I realized I've been running all sites on php version 8.2.7. I think we could upgrade all machines to at least 5.6. If that's not the case, there's also the possibility that the php 5.6 requirement set by relevanssi may not indicate earlier versions would have problems because before that they had not set a php requirement at all.

timmywil commented 1 year ago

Now that you say that, I'm not sure. I thought we wrote all the plugins.

Krinkle commented 1 year ago
timmywil commented 1 year ago

Thanks, it seems this has been fixed upstream through the use of a defined check.

timmywil commented 1 year ago

Is there a reason you linked 3.5.9? I understand not wanting to do a major version upgrade to latest (4.20.0), but the latest 3.x is 3.6.2 (or possibly "3.6.2.2")

Krinkle commented 1 year ago

I linked 3.5.9 as being the closest to the version we currently have. We wanted to link to relevanssi 3.3.8, which is what we have (per readme.txt), but that version isn't present in the canonical upstream repo. 3.5.9 is the oldest/closest I found.

I agree that in terms of upgrade, I suggest moving to the latest 3.x.

The full 3.x changelog is available at https://github.com/msaari/relevanssi/blob/3.6.2.2/readme.txt#L270-L420. Note that the old servers currently run WordPress 4.5 and PHP 5.4.

The 3.6.2.2 readme actually says it requires "PHP 5.6" (or later), so we may need to move to an older intermediate version first, or apply a manual patch, until we're fully on the new servers with WordPress 6.2 and PHP 7.4.

timmywil commented 1 year ago

It looks like the php requirement wasn't set at all until version 3.6. PHP 5.6 may be an arbitrary restriction.

Krinkle commented 1 year ago

Re-opening to trigger the new PHP 5.4 lint job, just in case :)

Krinkle commented 1 year ago

I updated the commit message to explicitly reference the source zip URL, and confirmed that rm -rf relevanssi; curl … | tar -xz -z; mv relevanssi-* relevanssi leaves no difference with this patch.

Merged in https://github.com/jquery/jquery-wp-content/commit/78880cdac26d14ba0215722fdea8d529a2b46dd3.