search

jquery / jquery-wp-content

WordPress themes and plugins for the jQuery sites
GNU General Public License v2.0
253 stars 169 forks source link

Add herodevs support. #464

Closed AndreAngelantoni closed 5 days ago

AndreAngelantoni commented 3 weeks ago

This support https://github.com/jquery/jquery-wp-content/issues/462.

Within this find:

  1. add status message top of screen on homepage
  2. add Support menu item to navigation bar
  3. add warning box to API pages
  4. add styling for the above

Please note: I'm unable to confirm that #3 is in the correct theme file as we could not get the API site to work locally (two devs, two different machines). The guidelines indicate that making this guess may be acceptable.

linux-foundation-easycla[bot] commented 3 weeks ago

CLA Not Signed

mgol commented 3 weeks ago

You'll need to sign our CLA. Follow the link from the EasyCLA bot.

AndreAngelantoni commented 3 weeks ago

@mgol thanks! Shortly after submitting, Joe and I did the paperwork. We should be good to go.

Also, I'm off-grid for the next nine days. Still would be great to move this forward will I'm gone if it's easy to do so. Joe can answer questions about why I did certain things (and we aren't attached to the details).

mgol commented 3 weeks ago

The EasyCLA check is still red. Can you make sure the process is followed? The EasyCLA bot provided a link above. Unfortunately, that's a blocker with following up on this.

joeeames commented 2 weeks ago

ok, i just submitted a ticket. I thought I already did this...sorry

AndreAngelantoni commented 1 week ago

@joeeames @mgol I thought I had signed correctly last time but I did it again just now as a corporate contributor. For good measure, I signed it individually just now (and use my andre@herodevs.com email address), too.

Michael, how do you recommend we proceed? The Not Covered badge is still present yet I believe I've done what's needed.

AndreAngelantoni commented 1 week ago

I think I figured out what's happening. The commits came in under my personal account. @joeeames I've sent a request to you but this time it will come from aangelinsf. Please approve and we should be good to go.

mgol commented 1 week ago

@AndreAngelantoni you can squash the commits into one and amend the author info, doing a git push --force-with-lease afterwards; then the check will pass.

AndreAngelantoni commented 1 week ago

Thanks, Michał. Timmy wants to work with me now that I'm back from vacation so the commits may yet change.

On Mon, Sep 9, 2024 at 3:42 PM Michał Gołębiowski-Owczarek < @.***> wrote:

@AndreAngelantoni https://github.com/AndreAngelantoni you can squash the commits into one and amend the author info, doing a git push --force-with-lease afterwards; then the check will pass.

— Reply to this email directly, view it on GitHub https://github.com/jquery/jquery-wp-content/pull/464#issuecomment-2339205057, or unsubscribe https://github.com/notifications/unsubscribe-auth/BE3WQBLGBWMMST7SAEIBNKTZVYI2TAVCNFSM6AAAAABNE7TJH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGIYDKMBVG4 . You are receiving this because you were mentioned.Message ID: @.***>

AndreAngelantoni commented 5 days ago

Closing in favor of https://github.com/jquery/jquery-wp-content/pull/467.