Closed PeterDaveHello closed 2 years ago
Hi @PeterDaveHello.
Thank you for your PR, saving bandwidth for our users is certainly important. However, this process should be automated by using a Grunt task since we've already Grunt in place (unless we're already doing something on the server which I'm missing @gnarf).
Can you send a PR based on my suggestion?
@AurelioDeRosa I know automated progress is important, but I wonder how often the images will be changed? Especially members image, I have this question because the png optimization using zopflipng will take a long time, if you tried it, you will know, that will totally slow down the whole build process, if the images are not changed so often, isn't pre-compression acceptable?
I'd agree that automation isn't that important here, but adding some notes about good compression tactics to the readme/contribute sites would probably be a good idea... On Apr 17, 2016 1:56 AM, "Peter Dave Hello" notifications@github.com wrote:
@AurelioDeRosa https://github.com/AurelioDeRosa I know automated progress is important, but I wonder how often the images will be changed? Especially members image, I have this question because the png optimization using zopflipng will take a long time, if you tried it, you will know, that will totally slow down the whole build process, if the images are not changed so often, isn't pre-compression acceptable?
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/jquery/jquery.org/pull/121#issuecomment-210961055
@gnarf What do you mean by the tactic used? Something like the tool adopted, the compression type, or the lossless compression vs non-lossless compression?
I can add a note in readme to talk about the tools and parameters I used to do the compression :smile:
Yup, basically we should have a guide about this, and spread info to the rest of @jquery/content when landing new images or image changes On Apr 17, 2016 10:43 AM, "Peter Dave Hello" notifications@github.com wrote:
I can add a note in readme to talk about the tools and parameters I used to do the compression [image: :smile:]
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/jquery/jquery.org/pull/121#issuecomment-211034386
@gnarf where should I put the guide? The readme in this repo?
I think this would be more of a contribute thing... On Apr 18, 2016 12:46 AM, "Peter Dave Hello" notifications@github.com wrote:
@gnarf https://github.com/gnarf where should I put the guide? The readme in this repo?
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/jquery/jquery.org/pull/121#issuecomment-211199193
I agree with @AurelioDeRosa i would prefer an automated approach. If this was truely just about jquery.org it would be fine but this effects all the websites. Most of the websites are also not maintained by @jquery/content but by individual team's members, and community contributions. If we just put this in readme it would have to go in every sites readme and would still likely be forgotten and ignored quickly.
As for concerns about build time. Its fairly simple to setup a task to only run on files which have changed. Also given how often these sites are updated i don't think build time is a huge concern.
So sometimes the best optimization is a different format image entirely, like using a PNG24 when you have a simple color pallette that fits in a gif... I don't think this is an automated solution, this is an education and external tooling problem... The tools already exist, you just need to remember to use them... Perhaps if you want an automation, a warning about images that are large or something similar. Also not all images need the same levels of compression, etc. On Apr 18, 2016 9:46 AM, "Alexander Schmitz" notifications@github.com wrote:
I agree with @AurelioDeRosa https://github.com/AurelioDeRosa i would prefer an automated approach. If this was truely just about jquery.org it would be fine but this effects all the websites. Most of the websites are also not maintained by @jquery/content https://github.com/orgs/jquery/teams/content but by individual team's members, and community contributions. If we just put this in readme it would have to go in every sites readme and would still likely be forgotten and ignored quickly.
As for concerns about build time. Its fairly simple to setup a task to only run on files which have changed. Also given how often these sites are updated i don't think build time is a huge concern.
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/jquery/jquery.org/pull/121#issuecomment-211386479
Do we have any final decision here? This PR is stale now.
Let's just close it.
Optimize images losslessly to save to bandwidth to transfer :)