search

jquery / jquery

jQuery JavaScript Library
https://jquery.com
MIT License
59.21k stars 20.59k forks source link

slideDown, show and more stopped working for `display: none` elements #2308

Closed phistuck closed 8 years ago

phistuck commented 9 years ago

Test case -

<!doctype html>
<script src="http://code.jquery.com/jquery-git2.js"></script>
<style>
div, p { display: none }
</style>
<div>stuff<br/>that<br/>takes<br/>a<br/>height</div>
<p>stuff<br/>that<br/>takes<br/>a<br/>height</p>
<script>
$("p").show();
$("div").slideDown();
</script>

Changing jquery-git2 to jquery-2.1.1 fixes the issue. This is a regression.

This is caused by https://github.com/jquery/jquery/commit/86419b10bfa5e3b71a7d416288ab806d47a31d1f

Eccenux commented 9 years ago

BTW. Surprisingly most of jQuery UI works. Only dialogs and drop-downs don't like jQ3.