jquery / jquery

jQuery JavaScript Library
https://jquery.com
MIT License
58.93k stars 20.62k forks source link

Build: add GitHub Actions workflow to update Filestash #5434

Closed timmywil closed 2 months ago

timmywil commented 2 months ago

Summary

Replaces the jenkins workflow to update git versions of jQuery on the Filestash server. The filestash environment is already set up in the jQuery repo settings and includes the necessary SSH private key and filestash server URL.

Here's a sample of the workflow running as a dry run: https://github.com/timmywil/jquery/actions/runs/8205613186/job/22442850764

We should disable the jenkins workflow before merging.

Checklist

Krinkle commented 2 months ago

The following look great:

The following could tighten it further:

Neither a big deals. LGTM as-is.

timmywil commented 2 months ago

The first suggestion sounds good to me, but I prefer to have control and consistency over the Node version everywhere we build. I've learned not to trust whatever Node version comes preinstalled in the runner image. We've been bitten by that before, and I don't want to be at the mercy of the image's update schedule. FWIW, that step usually takes less than a second and is the same for all workflows that build.

timmywil commented 2 months ago

I've applied "protected branches only" to the environment, which includes main and *-stable

timmywil commented 2 months ago

Thanks for making a list. I'll make those changes in a followup PR.

timmywil commented 2 months ago

Checked all files and they all updated as expected.