jquery / jquery

jQuery JavaScript Library
https://jquery.com
MIT License
58.93k stars 20.62k forks source link

Fix potential github action smells #5480

Closed ceddy4395 closed 3 weeks ago

ceddy4395 commented 3 weeks ago

Summary

Hey! 🙂 I want to contribute the following changes to your workflow:

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

Checklist

linux-foundation-easycla[bot] commented 3 weeks ago

CLA Signed


The committers listed above are authorized under a signed CLA.

timmywil commented 3 weeks ago

Thanks for your contribution. However, I think we're happy with the way it is.

Steps should only perform a single command

I normally agree with this, but it's okay to group commands when they are grouped logically to accomplish a single task (for instance, to set up SSH for uploading to Filestash). Feedback in GA logs is not necessary for each of those commands, and those commands are frequently run together. We only care if it failed to set up SSH, so they are grouped as a single action step.

Use cache parameter instead of cache option

I've used this before and prefer to have more control over the cache. The end result is similar, but we control the version used and the cache fallbacks.

Run CI on multiple language versions Run tests on multiple OS's

There's no need for this when testing jQuery. jQuery is a DOM library that is mainly used in the browser. We do run some smoke tests in multiple Node versions, but jQuery is not a Node or OS library. The browserstack workflow covers all of the browsers jQuery supports.

Thanks.