search

jquery / jqueryui.com

jQuery UI web site content
https://jqueryui.com
Other
132 stars 113 forks source link

`Sortable` examples include `disableSelection()` #116

Closed jhfrench closed 8 years ago

jhfrench commented 9 years ago

Within the sortable() documentation, all of the examples (except "Portlets") include disableSelection().

The documentation for disableSelection() says:

Disabling text selection is bad. Don't use this.

arthurvr commented 9 years ago

Besides from just being evil, that method is deprecated too (see #7755), so yes, we shouldn't be doing it in our examples too. Thanks for the report.

Within the sortable() documentation

It's used in some other demos too.

scottgonzalez commented 8 years ago

Yes, it's deprecated and it's bad, but we're not dropping it until the rewrites land since the interactions need to be updated first. Also, this applies to more than just sortable and all of the code lives in the jquery-ui repo, not this repo.