1.12 Upgrade Guide - Githubissues

jquery / jqueryui.com

jQuery UI web site content

https://jqueryui.com

Other

132 stars 113 forks source link

1.12 Upgrade Guide #123

Closed jzaefferer closed 8 years ago

jzaefferer commented 9 years ago

Replaces #107, now targets the 1-12 branch.

Still missing:

[x] Button: API, dropping support for radio/checkbox
[ ] Button: CSS only buttons
[x] Buttonset: Replaced by controlgroup
[ ] Effects: See API issue, what do we need to document here except for the transfer effect?
[ ] Renamed minified files, see #10674, do we need to mention this?

jzaefferer commented 9 years ago

Added button rewrite, covering updated options, buttonset and checkboxradio.

Remaining items:

Effects: See API issue, what do we need to document here except for the transfer effect?

Nothing to do here, as far as I can tell.

Renamed minified files, see #10674, do we need to mention this?

This only affects files created by the uglify task, files that we don't distribute anywhere. I see no reason to mention this in the upgrade guide.

If both my assumptions are correct, pending review of the button stuff, the upgrade guide is done. Minus whatever else I'm missing right now.

arschmitz commented 8 years ago

It is probably worth noting the changes to folder structure and core break up for those using amd or the files directly.

may also be worth noting the changes to amd for the demos and tests.

the css dependency comments are new also probably worth mentioning

jzaefferer commented 8 years ago

It is probably worth noting the changes to folder structure and core break up for those using amd or the files directly.

Addressed in 0cfe409852f0ae5764c75a141c67fc0e05bd389e

may also be worth noting the changes to amd for the demos and tests.

I don't see how that belongs in the upgrade guide. The demos on the website will be the same as before. For users of the library, this shouldn't make any difference.

the css dependency comments are new also probably worth mentioning

That can go into the blog post and should be added to http://learn.jquery.com/jquery-ui/environments/amd/ - but I don't think it belongs in the upgrade guide.

scottgonzalez commented 8 years ago

I agree with Jörn for demos/tests. For CSS dependencies, it's probably worth mentioning and just linking off to some other article. This will be useful for anyone that's doing custom builds. I have no idea how this would work with webpack.

jzaefferer commented 8 years ago

Added a fixup commit to address CSS dependencies. It very much leaves open the question of how to actually use these outside of download builder. We can update that later as more resources (articles, build tool plugins) become available.

jzaefferer commented 8 years ago

Replaced "non-transient" with "direct".

jzaefferer commented 8 years ago

This PR is currently against the 1-12 branch, which has just one commit, updating demos. Since there's no reason to block the upgrade guide until the 1.12 stable release, I suggest landing this in master instead, as a single commit.

scottgonzalez commented 8 years ago

I'll be reviewing this today, after the PEP meeting. We can definitely get it merged at that point, even if I find more that needs to be documented.

scottgonzalez commented 8 years ago

I merged just the upgrade guide into master.