search

jquery / jqueryui.com

jQuery UI web site content
https://jqueryui.com
Other
132 stars 113 forks source link

change http to https where applicable #140

Closed OmgImAlexis closed 8 years ago

OmgImAlexis commented 8 years ago

http://download.jqueryui.com redirects to https://jqueryui.com/download/, should this be changed in Gruntfile.js? http://ui.jquery.com/bugs redirects to https://jqueryui.com/bugs but that doesn't exit, what should this be changed to? https://ui.jquery.com/bugs redirects to https://jquery.com/ not sure why it doesn't match above. http://code.google.com/p/jquery-ui redirects to https://github.com/jquery/jquery-ui so I updated the links. http://groups.google.com/group/jquery-a11y redirects to https://groups.google.com/forum/#!forum/jquery-a11y so I updated the links. https://wiki.jqueryui.com has an incorrect SSL cert. http://xregexp.com/xregexp.js doesn't exist anymore, the site does though. http://jquery.github.com/cla.html is now at https://contribute.jquery.org/CLA/ so that's updated.

scottgonzalez commented 8 years ago

http://download.jqueryui.com redirects to https://jqueryui.com/download/, should this be changed in Gruntfile.js?

No, this is specifying a host, not a page to request. The download.jqueryui.com domain does exist and is used, it just doesn't serve an index page.

http://ui.jquery.com/bugs redirects to https://jqueryui.com/bugs but that doesn't exit, what should this be changed to?

https://bugs.jqueryui.com

https://ui.jquery.com/bugs redirects to https://jquery.com/ not sure why it doesn't match above.

https://bugs.jqueryui.com

http://code.google.com/p/jquery-ui redirects to https://github.com/jquery/jquery-ui so I updated the links.

I haven't looked through all the changes yet, but if you did a blank search and replace, this will cause bad URLs.

http://groups.google.com/group/jquery-a11y redirects to https://groups.google.com/forum/#!forum/jquery-a11y so I updated the links.

Ok.

https://wiki.jqueryui.com has an incorrect SSL cert.

We don't control that. These URLs should stay as HTTP.

http://xregexp.com/xregexp.js doesn't exist anymore, the site does though.

I suppose we can update this purely for the sake of not having a dead link.

http://jquery.github.com/cla.html is now at https://contribute.jquery.org/CLA/ so that's updated.

Thanks! I'll go through all the updates to make sure there are no issues.

OmgImAlexis commented 8 years ago

I'll fix these things in a bit, the part about bad spacing. You should add an editorconfig so things like this don't happen. I have my editor set my default to 4 spaces instead of tabs.

scottgonzalez commented 8 years ago

You should add an editorconfig so things like this don't happen.

We've got a discussion about this going on in https://github.com/jquery/contribute.jquery.org/issues/129 and https://github.com/jquery/api.qunitjs.com/pull/115.