search

jquery / sizzle

A sizzlin' hot selector engine.
https://sizzlejs.com
Other
6.29k stars 951 forks source link

Build: Run Karma tests sequentially in separate processes + other improvements #455

Closed mgol closed 5 years ago

mgol commented 5 years ago

Sizzle hasn't been able to finish all its unit tests successfully for a long time. This PR attempts to make it work again (at least most of the time).

  1. A new "karma-tests" task is created; it runs tests in various browser sets but does it sequentially in separate processes to avoid Karma bugs that cause browsers from previous sets to somehow still be waited on during subsequent runs, failing the build.
  2. Upgrade tested browsers
  3. Run iOS tests at the end (as it fails more often than other browsers)
  4. Use real iOS 10.3 device in Karma

We can't upgrade Karma as the latest version (4.2.0) hangs in IE 7 (IE 8 seems to work fine there).

Note: it's expected that tests fail on this PR when merged due to #454. I temporarily disabled oldFirefox tests & pushed it to origin to see if it will succeed other than that and it did: https://travis-ci.org/jquery/sizzle/builds/574066624 EDIT: That issue is fixed now.

mgol commented 5 years ago

The Firefox issue is fixed in a separate PR: #456.

mgol commented 5 years ago

Given one approval, I'm going to merge it to see if master gets green or if I need some followup work.

mgol commented 5 years ago

Here we are, the first successful master build on Travis since 7 months ago! 🎉 https://travis-ci.org/jquery/sizzle/builds/574903438