search

jquery / testswarm

Distributed continuous integration testing for JavaScript.
http://swarm.jquery.org
Other
967 stars 158 forks source link

IE11 UserAgent detection failed #284

Closed lcalvy closed 10 years ago

lcalvy commented 11 years ago

IE11 on Windows 8.1 preview is not well detected du to MSIE missing in user-agent string : 

ua-parser: stdClass Object (
 [browserFamily] => Other
 [browserMajor] =>
 [browserMinor] =>
 [browserPatch] =>
 [osFamily] => Windows
 [osMajor] =>
 [osMinor] =>
 [osPatch] =>
 [deviceFamily] => Other
 [deviceMajor] =>
 [deviceMinor] =>
) 
User-Agent string: Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko
lcalvy commented 11 years ago

I sent a pull request on ua-parser to support windows 8.1 as 'windows 8' family

Krinkle commented 11 years ago

Also note that to update the ua-parser registry, one should run the fetch ua-parser data step:

7. Fetch the latest user-agent information: php inc/libs/ua-parser/php/uaparser-cli.php -g

The ua database itself is not in the repository but only in your working copy. You could put that in a periodic crontab.

jzaefferer commented 10 years ago

@lcalvy was this resolved?

Krinkle commented 10 years ago

Works for me. This was fixed upstream in https://github.com/tobie/ua-parser/commit/fa7003f3.

Updating the ua-parser regex registry (not the library framework submodule) fixed it.