search

jquery / themeroller.jquerymobile.com

ThemeRoller site for jQuery Mobile
Other
140 stars 73 forks source link

Issue with add swatch when you import a CSS #186

Closed r-deleon closed 10 years ago

r-deleon commented 10 years ago

After I Import a theme if I want to add another swatch the last I have is override. Say the theme i have has swatch A and B. After I click on the add buton swatch C is added but swatch B is not anymore with the style I recently import.

first after

Not sure if i'm doing something wrong. Thanks.

r-deleon commented 10 years ago

Well...I tested on firefox and it works fine. The issue was on Google Chrome Version 33.0, Ubuntu 13.04

gabrielschulhof commented 10 years ago

@r-deleon could you please post the theme you are importing and give us a link to it? For which version of jQuery Mobile was the theme designed?

r-deleon commented 10 years ago

I'm still seeing this issue on Chrome Version: 34.0.1847.116 It was created for Jquery Mobile 1.3.2. Theme: https://gist.github.com/r-deleon/11403523

Import and try to add a new swatch.

gabrielschulhof commented 10 years ago

@r-deleon Thanks! Will do!

gabrielschulhof commented 10 years ago

OK. I've reproduced it. I guess it's only happening with 1.3.2 themes.

gabrielschulhof commented 10 years ago

Interestingly, the issue cannot be reproduced if you import your theme after having launched theme roller with ?ver=1.3.2 - that is, if you go straight to version 1.3.2. If, however, you launch it with the default version (currently 1.4.2), then select 1.3.2 from the dropdown, and then import the theme, adding a swatch will cause swatch b to no longer show.

gabrielschulhof commented 10 years ago

The issue can be reproduced with the latest FF.

gabrielschulhof commented 10 years ago

To reproduce:

  1. Open theme roller in the browser
  2. Switch to version 1.3.2
  3. Colour your first two swatches. Leave the third one alone
  4. Click download, give the theme the name "tmp", and open the file themes/tmp.css which is contained in the resulting zipfile with your favourite text editor.
  5. Copy the contents of the file to the clipboard.
  6. Close the browser containing theme roller, and re-open theme roller.
  7. Switch to version 1.3.2
  8. Click import
  9. Paste the text copied from the text editor into the textarea.
  10. Click "Import"
  11. Click "Add swatch..." in the big gray box next to swatch c.

At this point, swatch b assumes the colours of swatch c.

gabrielschulhof commented 10 years ago

To reproduce:

  1. Open theme roller in the browser
  2. Switch to version 1.3.2
  3. Colour your first two swatches. Leave the third one alone
  4. Click download, give the theme the name "tmp", and open the file themes/tmp.css which is contained in the resulting zipfile with your favourite text editor.
  5. Copy the contents of the file to the clipboard.
  6. Close the browser containing theme roller, and re-open theme roller.
  7. Switch to version 1.3.2
  8. Click import
  9. Paste the text copied from the text editor into the textarea.
  10. Click "Import"
  11. Click "Add swatch..." in the big gray box next to swatch c.

At this point, swatch b assumes the colours of swatch c.

I can no longer reproduce the problem via these steps after having landed the fix.