jquesnelle / nds4droid

nds4droid is a free and open source Nintendo DS emulator for Android smartphones
GNU General Public License v3.0
168 stars 40 forks source link

Version 47.1 #11

Open tangalbert919 opened 7 years ago

tangalbert919 commented 7 years ago

Lots of things are optimized here. Only the ARM binaries succeeded in compilation. x86 now utilizes AsmJIT, but whether or not it compiles remains unknown.

jquesnelle commented 7 years ago

I'll merge this in later today -- are there any other changes for 47?

tangalbert919 commented 7 years ago

At the moment, no.

NotTsunami commented 7 years ago

There actually are a few other things I'd like to push - although personally I don't think this is ready yet (just my opinion though).

tangalbert919 commented 7 years ago

I made an APK for this. One problem with it: It crashes on launch. Been working on compilation errors. I'll be debugging it now.

tangalbert919 commented 7 years ago

Come to think of it, I might just use the v48 branch to add 64-bit support. I can't seem to get anywhere with runtime with it because Lightning JIT doesn't like ARM64.

tangalbert919 commented 7 years ago

I have managed to get nds4droid to operate on 64-bit devices without crashing. To achieve this, follow these instructions (64-bit ARM devices only):

  1. Press the back button. Don't try running any ROMs or the app will crash.
  2. Go to the settings menu.
  3. For the Execution Engine, select the first option called "interpreter".
  4. You're done. You can now load a ROM without crashing and notice that performance is much better (although it still depends on what device you're using). I need to erase the key store from the build.gradle. This was to fix the whole "unsigned APK" error for the run configuration.
tangalbert919 commented 7 years ago

I'm done making pushes now. Looks like 64-bit devices are not friendly to the Threaded Interpreter or Lightning JIT (in other words, they crash). By default, the CPU Mode has been set to the normal interpreter as a workaround.

tangalbert919 commented 6 years ago

Almost an entire month has passed since this pull request has been made.

tangalbert919 commented 6 years ago

It has been one year and 5 days since this pull request was opened, and it's still open today. This is really nice, when you think about it.

ghost commented 3 years ago

Any news updates about this? Any plan to update the app on google playstore???

ffoxD commented 3 years ago

This PR will celebrate its 5th birthday this month! And guess what, it's still open! Nice.