jqujqu / EvoSim

Simulate epigenome evolution
GNU General Public License v3.0
0 stars 0 forks source link

duplicate functions in PhyloTreePreorder #14

Closed xjlizji closed 6 years ago

xjlizji commented 6 years ago

size_t count_leaves(const std::vector<size_t> &subtree_sizes); and size_t leafsize(const std::vector<size_t> &subtree_sizes); are same.

andrewdavidsmith commented 6 years ago

The second one is strangely named

On May 15, 2018, at 6:51 PM, Liz Ji notifications@github.com<mailto:notifications@github.com> wrote:

size_t count_leaves(const std::vector &subtree_sizes); and size_t leafsize(const std::vector &subtree_sizes); are same.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_jqujqu_EvoSim_issues_14&d=DwMFaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=2ti3K9K1XjkPszCPHB82Aw&m=GEJmQGjk_8Ce21zVQ5-M2xRHORcIyqCH4zgcqKYbS1Y&s=8bD6oglvXkX7oM6mhyTey41Kx3HbW3oLBEj2cYsmHgg&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AHBBgdayTnIJyoLkprg1MkvDx-5F2P9Qb1ks5ty4YdgaJpZM4UAhnO&d=DwMFaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=2ti3K9K1XjkPszCPHB82Aw&m=GEJmQGjk_8Ce21zVQ5-M2xRHORcIyqCH4zgcqKYbS1Y&s=zagzIFBXAklTRL3Dw5eJ6HCSKPlB3QFYbhTzj2sr1ak&e=.

xjlizji commented 6 years ago

The second one was removed.