Closed voided closed 4 years ago
Merging #105 into master will decrease coverage by
0.21%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 46.38% 46.17% -0.22%
==========================================
Files 22 22
Lines 2324 2324
==========================================
- Hits 1078 1073 -5
- Misses 1246 1251 +5
Impacted Files | Coverage Δ | |
---|---|---|
pyborg/pyborg_entrypoint.py | 39.62% <100%> (ø) |
:arrow_up: |
pyborg/pyborg/mod/mod_irc.py | 58.47% <0%> (-4.24%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d2efddc...13dce93. Read the comment docs.
Lemme test it rq, thanks for the pull request. Looks ok by eye though.
On Thu, Jan 16, 2020, 22:07 codecov[bot] notifications@github.com wrote:
Codecov https://codecov.io/gh/jrabbit/pyborg-1up/pull/105?src=pr&el=h1 Report
Merging #105 https://codecov.io/gh/jrabbit/pyborg-1up/pull/105?src=pr&el=desc into master https://codecov.io/gh/jrabbit/pyborg-1up/commit/d2efddc97075c51d3ecfdf5d4ea563bac32901d5?src=pr&el=desc will decrease coverage by 0.55%. The diff coverage is 100%.
[image: Impacted file tree graph] https://codecov.io/gh/jrabbit/pyborg-1up/pull/105?src=pr&el=tree
@@ Coverage Diff @@
master #105 +/-
==========================================
- Coverage 46.38% 45.83% -0.56%
==========================================
Files 22 22
Lines 2324 2315 -9
==========================================
- Hits 1078 1061 -17
- Misses 1246 1254 +8
Impacted Files https://codecov.io/gh/jrabbit/pyborg-1up/pull/105?src=pr&el=tree Coverage Δ pyborg/pyborg_entrypoint.py https://codecov.io/gh/jrabbit/pyborg-1up/pull/105/diff?src=pr&el=tree#diff-cHlib3JnL3B5Ym9yZ19lbnRyeXBvaW50LnB5 39.62% <100%> (ø) ⬆️ pyborg/pyborg/init.py https://codecov.io/gh/jrabbit/pyborg-1up/pull/105/diff?src=pr&el=tree#diff-cHlib3JnL3B5Ym9yZy9fX2luaXRfXy5weQ== 80% <0%> (-20%) ⬇️ pyborg/pyborg/mod/mod_irc.py https://codecov.io/gh/jrabbit/pyborg-1up/pull/105/diff?src=pr&el=tree#diff-cHlib3JnL3B5Ym9yZy9tb2QvbW9kX2lyYy5weQ== 58.47% <0%> (-4.24%) ⬇️ pyborg/pyborg/util/bottle_plugin.py https://codecov.io/gh/jrabbit/pyborg-1up/pull/105/diff?src=pr&el=tree#diff-cHlib3JnL3B5Ym9yZy91dGlsL2JvdHRsZV9wbHVnaW4ucHk= 60% <0%> (-1.3%) ⬇️ pyborg/pyborg/mod/mod_filein.py https://codecov.io/gh/jrabbit/pyborg-1up/pull/105/diff?src=pr&el=tree#diff-cHlib3JnL3B5Ym9yZy9tb2QvbW9kX2ZpbGVpbi5weQ== 29.62% <0%> (-1.28%) ⬇️ pyborg/pyborg/mod/mod_subtitle.py https://codecov.io/gh/jrabbit/pyborg-1up/pull/105/diff?src=pr&el=tree#diff-cHlib3JnL3B5Ym9yZy9tb2QvbW9kX3N1YnRpdGxlLnB5 41.26% <0%> (-0.92%) ⬇️ pyborg/pyborg/mod/mod_reddit.py https://codecov.io/gh/jrabbit/pyborg-1up/pull/105/diff?src=pr&el=tree#diff-cHlib3JnL3B5Ym9yZy9tb2QvbW9kX3JlZGRpdC5weQ== 36.84% <0%> (-0.83%) ⬇️ pyborg/pyborg/mod/mod_mastodon.py https://codecov.io/gh/jrabbit/pyborg-1up/pull/105/diff?src=pr&el=tree#diff-cHlib3JnL3B5Ym9yZy9tb2QvbW9kX21hc3RvZG9uLnB5 47.27% <0%> (-0.48%) ⬇️ pyborg/pyborg/pyborg.py https://codecov.io/gh/jrabbit/pyborg-1up/pull/105/diff?src=pr&el=tree#diff-cHlib3JnL3B5Ym9yZy9weWJvcmcucHk= 46.99% <0%> (-0.48%) ⬇️
Continue to review full report at Codecov https://codecov.io/gh/jrabbit/pyborg-1up/pull/105?src=pr&el=continue.
Legend - Click here to learn more https://docs.codecov.io/docs/codecov-delta Δ = absolute
(impact), ø = not affected, ? = missing data Powered by Codecov https://codecov.io/gh/jrabbit/pyborg-1up/pull/105?src=pr&el=footer. Last update d2efddc...13dce93 https://codecov.io/gh/jrabbit/pyborg-1up/pull/105?src=pr&el=lastupdated. Read the comment docs https://docs.codecov.io/docs/pull-request-comments . — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jrabbit/pyborg-1up/pull/105?email_source=notifications&email_token=AABLU444I4F2EJ5VLKW2FCLQ6EOGLA5CNFSM4KIBKZM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGJJFY#issuecomment-575444119, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABLU44GILWOPUP6KAPVZOTQ6EOGLANCNFSM4KIBKZMQ .
looks great, thanks!
This got busted in d692f888e335619a0e952531bc11a2ae2ac3932c - I got unlucky enough to bump into this right as I started toying with this bot. Let me know if
http
's argument should be changed instead.