add random reply rate for discord bot

[jrabbit]

toml returns a normal dict so when that key doesn't exist you get an error like the testsuite is showing. If you could test for the key (and its contents) that should work. also a test / updated fixtures would be excellent, but don't feel like you have to.

On Fri, Feb 21, 2020 at 11:00 AM Dan Pasanen notifications@github.com wrote:

---

You can view, comment on, or merge this pull request online at:

https://github.com/jrabbit/pyborg-1up/pull/113 Commit Summary

• add random reply rate for discord bot

File Changes

• M pyborg/example.discord.toml https://github.com/jrabbit/pyborg-1up/pull/113/files#diff-0 (3)
• M pyborg/pyborg/mod/mod_discord.py https://github.com/jrabbit/pyborg-1up/pull/113/files#diff-1 (7)

Patch Links:

• https://github.com/jrabbit/pyborg-1up/pull/113.patch
• https://github.com/jrabbit/pyborg-1up/pull/113.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jrabbit/pyborg-1up/pull/113?email_source=notifications&email_token=AABLU43Z6XXUGZMDGA67ZBTRD73CXA5CNFSM4KZFW5PKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPK36WA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABLU4423ZKKKYG2QOLAMWLRD73CXANCNFSM4KZFW5PA .

[invisiblek]

toml returns a normal dict so when that key doesn't exist you get an error like the testsuite is showing. If you could test for the key (and its contents) that should work. also a test / updated fixtures would be excellent, but don't feel like you have to. … On Fri, Feb 21, 2020 at 11:00 AM Dan Pasanen @.**> wrote: ------------------------------ You can view, comment on, or merge this pull request online at: #113 Commit Summary - add random reply rate for discord bot File Changes - M pyborg/example.discord.toml https://github.com/jrabbit/pyborg-1up/pull/113/files#diff-0 (3) - M* pyborg/pyborg/mod/mod_discord.py https://github.com/jrabbit/pyborg-1up/pull/113/files#diff-1 (7) Patch Links: - https://github.com/jrabbit/pyborg-1up/pull/113.patch - https://github.com/jrabbit/pyborg-1up/pull/113.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#113?email_source=notifications&email_token=AABLU43Z6XXUGZMDGA67ZBTRD73CXA5CNFSM4KZFW5PKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPK36WA>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABLU4423ZKKKYG2QOLAMWLRD73CXANCNFSM4KZFW5PA .

Sounds good, might be a couple days before I get a chance to update these. Thanks!

[codecov[bot]]

Codecov Report

Merging #113 into master will decrease coverage by 0.19%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #113     +/-   ##
=========================================
- Coverage   46.45%   46.25%   -0.2%     
=========================================
  Files          23       23             
  Lines        2441     2445      +4     
=========================================
- Hits         1134     1131      -3     
- Misses       1307     1314      +7

Impacted Files	Coverage Δ
pyborg/pyborg/mod/mod_discord.py	55.66% <100%> (+0.89%)	:arrow_up:
pyborg/pyborg/mod/mod_irc.py	58.47% <0%> (-4.24%)	:arrow_down:
pyborg/pyborg/pyborg.py	47.3% <0%> (-0.23%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c5a4b5...23d02e0. Read the comment docs.

[jrabbit]

Had to double check this actually worked I was expecting .get() but it works. Just for future reference, no need to force push to PRs, if they get messy I can easily squash them when I merge it.