search

jrabbit / pyborg-1up

:robot: A modern overhaul of an old favorite irc bot for multiple platforms
https://pyborg.readthedocs.io/en/latest/
GNU General Public License v3.0
33 stars 12 forks source link

Horribly throw together support for non-default ports #87

Closed NotActuallyTerry closed 5 years ago

NotActuallyTerry commented 5 years ago

The sanity checks are actually kinda useless right now but eh, it looks like an attempt was made so

jrabbit commented 5 years ago

sent a comment via email if it doesn't show up when github restabilizes i'll copy it over manually. something I didn't mention in that comment: updating the tests would be good 😸

jrabbit commented 5 years ago

ok doesn't seem like the email is gonna happen lol

Ok with adding the customization but we should avoid doing typechecking by hand and just use attrs on this class. We also can use full types since its 3.6+ only. Won't be able to write that just yet so if you could do that I'd be solid on merging.

jrabbit commented 5 years ago

Do you think you can do that? If you need specific help feel free to ask for it.