jraebrown / growl

Automatically exported from code.google.com/p/growl
0 stars 0 forks source link

Growl history doesn't properly handle NSURL's, possibly in the click context #342

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Have an app send an NSURL as part of a click context
2. Store that URL as part of the dictionary in the history database
3. Try to retrieve that dictionary.  

What is the expected output?
It works

What do you see instead?
It crashes

Attached is a crash log from a user on the discuss list, 
http://groups.google.com/group/growldiscuss/browse_thread/thread/15e9e69e5530a23
4

Original issue reported on code.google.com by dan...@growl.info on 28 Oct 2011 at 4:03

Attachments:

GoogleCodeExporter commented 8 years ago
I'm very sad to see no owner as of today. The bug is from October, and it keeps 
affecting me (and many other, I'm sure, I'm not using otherworldly apps).

Example from today

18/1/12 3:19:54.919 PM Growl: *** Terminating app due to uncaught exception 
'NSInvalidArgumentException', reason: '*** -[NSURL 
initWithString:relativeToURL:]: nil string parameter'
*** First throw call stack:
(
    0   CoreFoundation                      0x00007fff95362286 __exceptionPreprocess + 198
    1   libobjc.A.dylib                     0x00007fff9916ed5e objc_exception_throw + 43
    2   CoreFoundation                      0x00007fff953620ba +[NSException raise:format:arguments:] + 106
    3   CoreFoundation                      0x00007fff95362044 +[NSException raise:format:] + 116
    4   Foundation                          0x00007fff8e763db1 -[NSURL(NSURL) initWithString:relativeToURL:] + 83
    5   Foundation                          0x00007fff8e7f4cb4 -[NSURL(NSURL) initWithCoder:] + 134
    6   Foundation                          0x00007fff8e7a086b _decodeObjectBinary + 2860
    7   Foundation                          0x00007fff8e7a1a4a -[NSKeyedUnarchiver _decodeArrayOfObjectsForKey:] + 1193
    8   Foundation                          0x00007fff8e779cde -[NSDictionary(NSDictionary) initWithCoder:] + 703
    9   Foundation                          0x00007fff8e7a086b _decodeObjectBinary + 2860
    10  Foundation                          0x00007fff8e79fb86 _decodeObject + 201
    11  Foundation                          0x00007fff8e7e408a +[NSKeyedUnarchiver unarchiveObjectWithData:] + 95
    12  Foundation                          0x00007fff8e8e4485 -[_NSKeyedUnarchiveFromDataTransformer transformedValue:] + 30
    13  CoreData                            0x00007fff8d737204 _prepareResultsFromResultSet + 3204
    14  CoreData                            0x00007fff8d734f89 newFetchedRowsForFetchPlan_MT + 2089
    15  CoreData                            0x00007fff8d721674 -[NSSQLCore objectsForFetchRequest:inContext:] + 532
    16  CoreData                            0x00007fff8d7211dd -[NSSQLCore executeRequest:withContext:error:] + 221
    17  CoreData                            0x00007fff8d720728 -[NSPersistentStoreCoordinator executeRequest:withContext:error:] + 1704
    18  CoreData                            0x00007fff8d71ea03 -[NSManagedObjectContext executeFetchRequest:error:] + 579
    19  Growl                               0x000000010c61d9fb __54-[GrowlNotificationDatabase userReturnedAndClosedList]_block_invoke_0 + 209
    20  CoreData                            0x00007fff8d767acd developerSubmittedBlockToNSManagedObjectContextPerform + 93
    21  libdispatch.dylib                   0x00007fff8e32772a _dispatch_main_queue_callback_4CF + 308
    22  CoreFoundation                      0x00007fff952f74dc __CFRunLoopRun + 1724
    23  CoreFoundation                      0x00007fff952f6ae6 CFRunLoopRunSpecific + 230
    24  HIToolbox                           0x00007fff987f23d3 RunCurrentEventLoopInMode + 277
    25  HIToolbox                           0x00007fff987f963d ReceiveNextEventCommon + 355
    26  HIToolbox                           0x00007fff987f94ca BlockUntilNextEventMatchingListInMode + 62
    27  AppKit                              0x00007fff91a403f1 _DPSNextEvent + 659
    28  AppKit                              0x00007fff91a3fcf5 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 135
    29  AppKit                              0x00007fff91a3c62d -[NSApplication run] + 470
    30  Growl                               0x000000010c60e7a9 -[GrowlApplication run] + 182
    31  AppKit                              0x00007fff91cbb80c NSApplicationMain + 867
    32  Growl                               0x000000010c5f68a5 main + 134
    33  Growl                               0x000000010c5ebbc4 start + 52
    34  ???                                 0x0000000000000002 0x0 + 2
)

Original comment by gglanz...@gmail.com on 18 Jan 2012 at 3:44

GoogleCodeExporter commented 8 years ago
Keep in mind that we're working on both 1.3.3 and 1.4 right now, with fixes in 
both.

Original comment by ch...@growl.info on 18 Jan 2012 at 11:51

GoogleCodeExporter commented 8 years ago
Also that once we know what to fix, then it'll get assigned to a milestone. At 
the moment it's still being looked at.

Original comment by ch...@growl.info on 19 Jan 2012 at 12:03

GoogleCodeExporter commented 8 years ago

Original comment by ch...@growl.info on 19 Jan 2012 at 10:20

GoogleCodeExporter commented 8 years ago

Original comment by ch...@growl.info on 25 Jan 2012 at 10:42

GoogleCodeExporter commented 8 years ago

Original comment by ch...@growl.info on 4 Feb 2012 at 9:49

GoogleCodeExporter commented 8 years ago
what non-otherworldly apps are you using? its definitely the result of an 
application passing a NSURL as the click context, which is getting archived by 
apple's code improperly and then improperly unarchived.

Original comment by r...@growl.info on 11 Feb 2012 at 7:04

GoogleCodeExporter commented 8 years ago
I think it may be Delibar.app

But since its latest updated, it seems like the issue is gone. Probably the app 
is not passing NSURL's anymore.

Original comment by gglanz...@gmail.com on 14 Feb 2012 at 8:11

GoogleCodeExporter commented 8 years ago

Original comment by ch...@growl.info on 21 Jun 2012 at 3:36

GoogleCodeExporter commented 8 years ago

Original comment by ch...@growl.info on 18 Jul 2012 at 5:10