search

jraebrown / growl

Automatically exported from code.google.com/p/growl
0 stars 0 forks source link

GNTP needs an asynchronous method for handling url based icons #423

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Send a URL to a web based icon on a server that is unreliable in Growl 1.3.2
2. Growl calls dataWithContentsOfURL
3. ...
4. Profit?

What is the expected output?
That growl continues downloading the file asynchronously

What do you see instead?
That growl hangs

Growl needs a growl.app wide image caching system, and this would be the best 
place to have it try downloading an icon in the background, and when its 
finished, anything that is bound to the image in the image cache could be 
updated automatically.

Original issue reported on code.google.com by dan...@growl.info on 17 Jan 2012 at 5:45

GoogleCodeExporter commented 8 years ago

Original comment by ch...@growl.info on 19 Jan 2012 at 10:45

GoogleCodeExporter commented 8 years ago

Original comment by dan...@growl.info on 6 Feb 2012 at 4:54

GoogleCodeExporter commented 8 years ago 
I just purchased Growl 1.3.3 from the App Store and this bug is pretty 
annoying. I use rSpec and Guard to for test-driven Ruby development, and in the 
new paid version of Growl the helpful notification icons that I've grown 
accustomed to no longer work. Apparently this was working fine in 1.3.2, but I 
can't download that.

Original comment by james.d...@protolif.com on 9 Feb 2012 at 6:20

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
I'm in agreement with James comment.

As a paying user, I would like to be able to download a working version such as 
1.3.2.

Also, will this be fixed in 1.4?

Original comment by barry.al...@gmail.com on 25 Feb 2012 at 5:40

GoogleCodeExporter commented 8 years ago 
We had to disable it in 1.3.3 because the method used was causing 100% CPU. I'm 
certain that you understand that 100% CPU is a bad idea as compared to 
displaying an image.

It's addressed in 1.4, we just needed a bit more time to do so. 1.4 is in beta 
testing and will be submitted to the app store as soon as testing completes.

Original comment by ch...@growl.info on 25 Feb 2012 at 5:45

GoogleCodeExporter commented 8 years ago 
Bah, sorry, one thing. We had to disable the images in 1.3.3. That doesn't make 
the images problem as something asynchronous. That's different.

Anyhow, it should be fixed in 1.4. If not in 1.4, then 2.0.

Original comment by ch...@growl.info on 25 Feb 2012 at 5:46

GoogleCodeExporter commented 8 years ago 
Ah cool!  I'll beta 1.4 if you'd like.  Awesome fast response too! :D

Original comment by barry.al...@gmail.com on 25 Feb 2012 at 5:59

GoogleCodeExporter commented 8 years ago 
Apologies, this is not fixed in 1.4, there was a mixup in communication, we 
didn't have time with other issues we were working to resolve to get into this. 
 Growl 2.0 turns back on the old blocking method, but we have moved the 
delegate queue for the sockets to the background concurrent queue, so it wont 
block growl.  Apologies for the delay in getting this done.

Original comment by dan...@growl.info on 5 Apr 2012 at 1:24

GoogleCodeExporter commented 8 years ago 
Hello do you have already any estimate for the new changes?

Kinda sad to not be able to use this as like previous posters just paid for 
Growl today and was really expecting it work seamlessly

Original comment by pkunha@gmail.com on 18 May 2012 at 2:58

GoogleCodeExporter commented 8 years ago 
Unfortunately no. 1.4 had an issue crop up in networking that we had to deal 
with.  The issue turned out to be much bigger than we thought, and stems from a 
basic flaw in the design of networking, and so the networking code is being 
rewritten for 1.4.  I do not know if this issue will be resolved at the same 
time in 1.4, but if not, it will be fixed in 2.0 as stated, although this can't 
really be called fixed in source anymore, as the fix will be different than it 
is presently in the 2.0 branch.

Original comment by dan...@growl.info on 18 May 2012 at 3:35

GoogleCodeExporter commented 8 years ago 
Fixing this one issue would make be reason enough for me to repurchase growl at 
the app store.... just saying!

Original comment by bob.wa...@47hats.com on 30 May 2012 at 3:47

GoogleCodeExporter commented 8 years ago 
Presently this should be fixed in the new 2.0 stack, we process this on a 
background thread, not the main thread, so the blocking method we had in place 
before is now ok to use (note, could lead to an abundance of threads, still not 
a great solution, but at least we won't be blocking the main thread anymore). 

Annnd back to FixedInSource

Original comment by dan...@growl.info on 16 Jul 2012 at 8:10

GoogleCodeExporter commented 8 years ago 
Growl 2 is released, marking these as fixed.

Original comment by ch...@growl.info on 20 Sep 2012 at 3:16

GoogleCodeExporter commented 8 years ago

Original comment by ch...@growl.info on 11 Jan 2013 at 6:27