search

jraebrown / growl

Automatically exported from code.google.com/p/growl
0 stars 0 forks source link

Forwarding forwards Notification Center already seen flag #580

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Setup computer as server
2. Setup another as client - either subscribe to server, or server forward to 
client
3. Set both to use Notification Center
4. Send notification from app using framework which supports sending to NC

What is the expected output?
That both computers display note using NC

What do you see instead?
Client flakes out and only logs the notification

You can get around this by not using NC support on the server.

The exact cause of this is that we send an already seen flag when frameworks 
that can send to NC do, so that Growl doesn't double display the notification.  
This flag stays in the notification dict when we send it to forwarding or 
subscribing, and the client receiving it sees that flag, and doesn't display to 
NC.  

Fixing will require that we remember that this code is used in the framework, 
XPC (both for the SDK and Growl.app), and the server in Growl.app.  Preferably 
we should remove the flag before sending, as well as ignore the flag incoming.

I want to try and find a fix for 2.1, but it needs to be done right.

Original issue reported on code.google.com by dan...@growl.info on 22 Apr 2013 at 10:47

GoogleCodeExporter commented 8 years ago 
Fixed in source in [ca97f71278e2] for Growl 2.1.

Found good points to add this just outside the shared GNTP code, so that only 
outgoing and incoming remote notifications have the flag stripped.

Original comment by dan...@growl.info on 24 Apr 2013 at 11:07