search

jraebrown / growl

Automatically exported from code.google.com/p/growl
0 stars 0 forks source link

For non-registered applications, Growl is responding with GNTP error code 402 instead of error code 401 #623

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Remove the registered application in Growl.
2. Send a GNTP NOTIFY request.

What is the expected output?
(from http://www.growlforwindows.com/gfw/help/gntp.aspx#errorcodes)
Error code 401:
"UNKNOWN_APPLICATION
Application is not registered to send notifications"

What do you see instead?
Error code 402:
"UNKNOWN_NOTIFICATION
Notification type is not registered by the application"

What version of the product are you using? On what operating system?
2.1.3 on Mac OS X 10.9 (Mavericks)

Please provide any additional information below.
Wireshark screen capture attached.

GfW 2.0.9 responds (correctly, I believe) with error code 401.

In order to keep network traffic at a minimum, I'm only sending a GNTP REGISTER 
request if a NOTIFY request fails with error code 401. I had gotten the GfW 
implementation to work flawlessly so then I started working on the Mac 
implementation and noticed that the Mac Growl error code was different from GfW.

Mac Growl appears to be reacting to the lack of Notification-Name by giving 
error code 402, instead of first checking to see if Application-Name is 
registered.

Original issue reported on code.google.com by starman617@gmail.com on 7 Nov 2013 at 8:14

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by rarich...@gmail.com on 19 Nov 2013 at 4:47

GoogleCodeExporter commented 8 years ago

Original comment by rarich...@gmail.com on 6 Mar 2014 at 4:41

GoogleCodeExporter commented 8 years ago 
fixed as of 9dfaacda1b32ae11fb1b71f4923ac06f5ed9a004 on default

Original comment by rarich...@gmail.com on 6 Mar 2014 at 4:55