jrallison / authlogic_oauth

Authlogic OAuth is an extension of the Authlogic library to add OAuth support. OAuth can be used to allow users to login with their Twitter credentials.
authlogic-oauth.heroku.com
MIT License
165 stars 25 forks source link

validation option ":if" is ignored #5

Open bfolkens opened 14 years ago

bfolkens commented 14 years ago

I had a similar issue with the openid plugin since it uses the same logic.

For the validates_length_of_password_field_options, validates_confirmation_of_password_field_options, and validates_length_of_password_confirmation_field_options the :if option is ignored. It appears that a merge is executed against the options hash, overwriting the :if option. Can we change this to a reverse_merge? http://gist.github.com/251423

(I wanted to run this against the test suite but I couldn't get the suite to pass regardless of this patch's presence)