jrallison / rollout_ui

RolloutUI: A slick way to rollout features in your web app.
MIT License
137 stars 86 forks source link

Fix monkey patch for Rollout 1.2.0 #15

Closed ches closed 11 years ago

ches commented 12 years ago

The latest Rollout makes the second argument of active? optional -- if nil it checks if a feature is globally active. Adding the default to the monkey patch should be backwards compatible with older versions of Rollout for non-pathological cases since there is no arity change.

ches commented 12 years ago

Good case for groaning about monkey patches :weary: I tested something on a feature branch where RolloutUI wasn't installed yet, merged the branch to mainline where it was installed, failed to adequately test the scenario again after the merge, and it cost me smooth dark launch of a new feature after deploying it and discovering the need for this patch :sob:

mmzoo commented 12 years ago

+1

gingerlime commented 12 years ago

+1

jrallison commented 11 years ago

Thanks Ches!

mmzoo commented 11 years ago

Thank you!