Remove call do #delegate so we can run outside of Rails.

jrallison / rollout_ui

RolloutUI: A slick way to rollout features in your web app.

MIT License

137 stars 86 forks source link

Remove call do #delegate so we can run outside of Rails. #3

Closed Bira closed 12 years ago

Bira commented 12 years ago

Running rollout_ui as a standalone Sinatra/Rack app would cause it to crash as it loaded features, because feature.rb used a method from ActiveSupport, which is not one of rollout_ui's runtime dependency.

I changed the Feature class to be independent of ActiveSupport, which should allow it to work in both modes without issue. No new tests were added, since the old tests cover the same functionality. I'm not sure how to test for this specific bug in the existing specs, since they require Rails.

jrallison commented 12 years ago

Thanks, Ubiratan!

I'll merge in this pull request.

This does bring up a good point. I should have some test coverage for the non-Rails use case. Maybe that means another test suite, I don't know.