jrallison / rollout_ui

RolloutUI: A slick way to rollout features in your web app.
MIT License
137 stars 86 forks source link

rollout_ui is incompatible with rollout > 2.1.0 #35

Open sophiedeziel opened 8 years ago

sophiedeziel commented 8 years ago

I updated all my gems this week and I had a problem with rollout and rollout UI.

That error showed up in the view:

undefined method `join' for #<Set: {}>
/Users/sdeziel/.rvm/gems/ruby-2.2.4@express/gems/rollout_ui-0.3.0/lib/rollout_ui/engine/app/views/rollout_ui/features/_feature.html.erb:31

The faulty line:

<input class="users" type="text" name="users[]" value="<%= feature.user_ids.join(",") %>" data-placeholder="Enter User ID" />

I looked into rollout changes and since v2.2.1, Set is used instead of Array for users. https://github.com/FetLife/rollout/commit/5b2615e2916a86f297d24dcc7c95c2e5cfe5b20b

sarahjschultz commented 8 years ago

+1 to this issue -- seeing it in our project as well.