Closed midu closed 5 years ago
(note: these commits were paired with @kevinbongart)
I'm a bit confused. Why is it needed to add a feature to an environment before deploy?
If the feature isn't added, it seems like it should behave cleanly:
Can you help me understand the use case for needing to populate redis prior to the deploy?
Also, I'd prefer not to downgrade Rollout. What isn't compatible with ruby 1.8.7 in rollout 1.1? That may be an issue to fix in rollout itself.
Well, the use case we have is this:
we will only hit a rollout.active?(:feature) after doing something a bit long to do (on staging) and that we can not do on production (eg: publish a challenge)
Until then, the feature key won't be in redis which means it won't be in rollout ui, which is a little bit problematic.
Ah, I see. I get it now. Thanks.
And the design maintainer for the UI is Holly, so she may be able to help. :)
for the rollout version part, you're right. I'll see what I can do about it tomorrow
Hey @jrallison I think we are waiting on you to accept this pull request. No rush, just FYI :)
@returntrue we're working on some issues on other pull requests
OK fine I take it back
Any word from Holly on design?
Holly and I paired to make it look better. A pull request is open on Stefano's repo but still needs some love.
+1
+1. Any status on this?
Bring back ruby 1.8.7 compatibility
Rollout 1.1.0
is not compatible withruby 1.8.7
and most of the code inrollout_ui
does not take advantages of the changes brought by1.1.0
so I took the liberty allowing the previous version.(tests pass on both versions)
Feature#percentage returns 0
Because
nil
and0
% mean the same thing (here).Remove ActiveRecord from the dummy app
So no database is needed for testing
Allow creation of a feature via Rollout UI
This is the main reason for this fork.
We needed a strategy to add a feature in rollout before pushing it from dev to prod (or other environments).
The choices were some rake task to run on deploy or adding the functionality to rollout ui. The latter allows non(-too)-tech people to do it as well and prevents having to ssh onto a server or deploy an app just to create a redis key.
The newly created feature is activated for no one.
It's definitely not as pretty as it could be but this is where my designer skills stop.