jrallison / rollout_ui

RolloutUI: A slick way to rollout features in your web app.
MIT License
138 stars 87 forks source link

Add ability to create a feature in the UI #5

Closed midu closed 5 years ago

midu commented 12 years ago

Bring back ruby 1.8.7 compatibility

Rollout 1.1.0 is not compatible with ruby 1.8.7 and most of the code in rollout_ui does not take advantages of the changes brought by 1.1.0 so I took the liberty allowing the previous version.

(tests pass on both versions)

Feature#percentage returns 0

Because nil and 0% mean the same thing (here).

Remove ActiveRecord from the dummy app

So no database is needed for testing

Allow creation of a feature via Rollout UI

This is the main reason for this fork.

We needed a strategy to add a feature in rollout before pushing it from dev to prod (or other environments).

The choices were some rake task to run on deploy or adding the functionality to rollout ui. The latter allows non(-too)-tech people to do it as well and prevents having to ssh onto a server or deploy an app just to create a redis key.

The newly created feature is activated for no one.

It's definitely not as pretty as it could be but this is where my designer skills stop.

midu commented 12 years ago

(note: these commits were paired with @kevinbongart)

jrallison commented 12 years ago

I'm a bit confused. Why is it needed to add a feature to an environment before deploy?

If the feature isn't added, it seems like it should behave cleanly:

Can you help me understand the use case for needing to populate redis prior to the deploy?

jrallison commented 12 years ago

Also, I'd prefer not to downgrade Rollout. What isn't compatible with ruby 1.8.7 in rollout 1.1? That may be an issue to fix in rollout itself.

midu commented 12 years ago

Well, the use case we have is this:

we will only hit a rollout.active?(:feature) after doing something a bit long to do (on staging) and that we can not do on production (eg: publish a challenge)

Until then, the feature key won't be in redis which means it won't be in rollout ui, which is a little bit problematic.

jrallison commented 12 years ago

Ah, I see. I get it now. Thanks.

jrallison commented 12 years ago

And the design maintainer for the UI is Holly, so she may be able to help. :)

midu commented 12 years ago

for the rollout version part, you're right. I'll see what I can do about it tomorrow

returntrue commented 12 years ago

Hey @jrallison I think we are waiting on you to accept this pull request. No rush, just FYI :)

midu commented 12 years ago

@returntrue we're working on some issues on other pull requests

returntrue commented 12 years ago

OK fine I take it back

jrallison commented 12 years ago

Any word from Holly on design?

KevinBongart commented 12 years ago

Holly and I paired to make it look better. A pull request is open on Stefano's repo but still needs some love.

cmer commented 11 years ago

+1

andrewhao commented 10 years ago

+1. Any status on this?