search

jrallison / rollout_ui

RolloutUI: A slick way to rollout features in your web app.
MIT License
137 stars 86 forks source link

Add users by email or whatever #9

Open Empact opened 12 years ago

Empact commented 12 years ago

This allows the user to set a field other than id for use in the third column.

The user calls: RolloutUi.find_users_by(:email), and the email field is used to Users. The user can also set the target user class for this operation via RolloutUi.user_class =.

The changes would need to be carried over to the sinatra side as well before they're released, and there's room to debate over whether this is too general or not general enough a solution, but this is good enough for my purposes, so I submit it for your consideration.

There are also some minor incidental fixes included in this pull request, most notably: 5f1aa29

nfedyashev commented 6 years ago

Just my 2 cents: it would be much easier for end users if user_name_field could be configured globally. Meanwhile I'm forking the fork.

@Empact thanks for your diff anyway! Much appreciated