jramosd / javachromiumembedded

Automatically exported from code.google.com/p/javachromiumembedded
0 stars 0 forks source link

Mac: Use correct paths for Java 7 #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Set jdk_directory within environment variable GYP_DEFINES to the Java7 JDK 
(instead of Java6 framework path)

e.g. if you have Java7u40:

export GYP_DEFINES="jcef_platform=macosx64 
jdk_directory=/Library/Java/JavaVirtualMachines/jdk1.7.0_40.jdk/Contents/Home 
target_arch=x64" 

2. gclient runhooks
3. open Xcode project and try to build All(jcef project)

What is the expected output? What do you see instead?
Build fails because jcef.gyp points to the wrong java library and java header 
paths 

Please provide any additional information below.

Attached you'll find a patch file which
(a) fixes the jcef.gyp to the Java7 target
(b) adds definition for JNIEXPORT to util.h due its missing within java7u40 and 
prior versions
(b) moves the tests application "MainFrame" to package "tests" to comply to java
(c) fixed the script files to call tests.MainFrame instead of MainFrame

Please correct the wiki page BranchesAndBuildings within the point "export 
GY_DEFINES" corresponding

Original issue reported on code.google.com by k...@censhare.de on 15 Jan 2014 at 10:25

Attachments:

GoogleCodeExporter commented 9 years ago
Please update the wiki page BranchesAndBuildings as well. See attached patch

Original comment by k...@censhare.de on 15 Jan 2014 at 11:35

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, looks good. I'll commit it once I've had a chance to test on OS X.

Original comment by magreenb...@gmail.com on 22 Jan 2014 at 3:16

GoogleCodeExporter commented 9 years ago
Added in revision 17 with minor changes (needed to also update scripts in 
tools/distrib).

Original comment by magreenb...@gmail.com on 30 Jan 2014 at 4:15