Closed numiralofe closed 4 years ago
@numiralofe thanks for the report, I will look into this as soon as possible.
hi,
Thanks for the update :) updated to 0.2.1 but I was running tests again and I am finding the same problem :( being that now with logs in debug i can't see any panic error message, but still with jobs with more that 1 group, the groups that have the scaling nomad metada are not working, just for sanity I confirmed that putting back 1 group works as expected.
Thanks
@numiralofe are you able to provide an example job file to reproduce this? The trace included in the issue pointed to the exact code changed, so I am keen to learn where this stems from and fix it once and for all for you.
You say you're not seeing the panic, which is one problem solved, but now you're not seeing scaling when there should be an event? If you have any debug logs around this period that would also help.
@jrasell i am really sorry for my mistake and you are absolutely right :)
i did one more test and it works as expected and the bug is fixed, i think that probably when I was looking at the WebUI and the logs, somehow I got confused and missed the scaling event.
As a result i have also submitted a small pull request adding that info on the WebUi, i think that from the operator perspective its really useful have on the WebUi which direction the event took.
Thanks once again and sorry for the confusion.
@numiralofe I appreciate you checking; its often rare in OSS to get this kind of follow up so thanks and I am happy we managed to get the issue sorted. Thanks also for the PR, i'll get onto that now!
@jrasell no worries :) i am to use sherpa in a prd setup also I am from "the time" when "giving back" to the community and improve it yourself was a regular practice :)
hi All,
Env: sherpa: 0.2.0 / nomad 0.9.5
Problem: I have a nomad job where i have multiple groups defined, some with sherpa meta to enable scaling policies and other groups without any scaling police, also, sherpa policies are defined inside the group block.
If i curl the api i can see that the scaling police for the dynamic bit is properly set:
but after putting some load on the job, i am getting the following on the sherpa logs: