jrblevin / markdown-mode

Emacs Markdown Mode
http://jblevins.org/projects/markdown-mode/
GNU General Public License v3.0
877 stars 160 forks source link

"Row size" and "Column size" in `markdown-insert-table` are confusing #771

Closed umanwizard closed 1 year ago

umanwizard commented 1 year ago

markdown-insert-table prompts for number of rows with the prompt "Row size", and similarly for columns. However, I always expect "Row size" to mean the number of entries/datums in a row; i.e., its with, rather than the number of rows in the entire table.

Suggest this change:

diff -u --label /home/brennan/.emacs.d/elpa/markdown-mode-20230522.147/markdown-mode.el --label \#\<buffer\ markdown-mode.el\> /home/brennan/.emacs.d/elpa/markdown-mode-20230522.147/markdown-mode.el /tmp/buffer-content-em3a70
--- /home/brennan/.emacs.d/elpa/markdown-mode-20230522.147/markdown-mode.el
+++ #<buffer markdown-mode.el>
@@ -9736,8 +9736,8 @@
 Optional arguments ROWS, COLUMNS, and ALIGN specify number of
 rows and columns and the column alignment."
   (interactive)
-  (let* ((rows (or rows (string-to-number (read-string "Row size: "))))
-         (columns (or columns (string-to-number (read-string "Column size: "))))
+  (let* ((rows (or rows (string-to-number (read-string "Number of rows: "))))
+         (columns (or columns (string-to-number (read-string "Number of columns: "))))
          (align (or align (read-string "Alignment ([l]eft, [r]ight, [c]enter, or RET for default): ")))
          (align (cond ((equal align "l") ":--")
                       ((equal align "r") "--:")