jrbudda / Sentry

Citizens2 Town Sentry Character
12 stars 20 forks source link

Some Heroes skills do not damage Sentries #192

Closed Eliasar closed 10 years ago

Eliasar commented 10 years ago

Issue: When casting certain skills from Heroes, Sentries that are vulnerable to normal attacks (axe, sword, bow and arrow, fist) take 0.0 damage. Sentries do not take damage from either direct sources (no in-game item associated), lightning skills, or snowballs (icebolt and firebolt).

Plugins: Spigot, Citizens2, Sentry, Heroes, Vault

Spigot version: 1.7.2-R0.2, build 1204 Citizens2 version: Sentry version: 1.8 Heroes version: 1.5.5.1 Vault version: 1.2.29-b370

Steps to reproduce:

Sentry returns the following message (picture shown using firebolt, bolt, and flamearrow, which is a skill to enchant bows with flame) Heroes-Sentry-Damage-Issues

jrbudda commented 10 years ago

Damage in minecraft is based on events, when you hit someone with, say, a snowball, there is an event, each plugin gets passed this event in turn. Heroes sees it and applies the correct damage to the thing that was hit. When the event gets to sentry, its still just a snowball, which do 0 damage. So whats going on here is that Heroes isn't applying any damage to the Sentry, and there is no damage for Sentry to apply.

There's nothing I can do from the sentry side to identify a Heroes skill and handle it. Heroes would have to do it.