search

jrbudda / Vivecraft_112

VR mod for Minecraft. For Minecraft version 1.12.2
http://www.vivecraft.org/
Other
125 stars 31 forks source link

Patreon file should be cached #129

Open Johni0702 opened 5 years ago

Johni0702 commented 5 years ago

https://github.com/jrbudda/Vivecraft_112/blob/d994f51126271afbcca213f8ac776febeddedcfd/patches/net/minecraft/client/entity/AbstractClientPlayer.java.patch#L25-L28 This re-fetches the patreon list every time a player entity is created.

As is, that's already far more often than necessary but once you add in a mod which creates a temporary player entity each frame for use as mc.renderViewEntity (e.g. BetterPortals), it practically kills your game within seconds (https://paste.dimdev.org/pobososeku.cs). The server probably isn't too happy about it either (though at least requests aren't run in parallel).

Techjar commented 5 years ago

To be fair BetterPortals doesn't work anyways, but yeah that's really silly.

Also the server is some GoDaddy shared hosting so it can probably handle it.