"Reverse Hands" option needs work

[cmbruns]

This is a follow on to an issue in one of the older vivecraft repos https://github.com/jrbudda/Vivecraft_110/issues/105

Expected Behavior:

1. The "main hand" tool appears on the same side in both VR and non-VR play
2. A third-person observer sees the same main-hand side and orientation as the VR player does.
3. There should be just one setting for the "main hand" leftiness.

Actual Behavior:

1. In some cases, the "main hand" tool appears on different sides of the body in VR vs. non-VR play. The two play modes should be consistent.
2. In some cases, the "main hand" tool or pose appearance differs between first-person and third-person views. The hands should appear consistently when viewed by one's self, and by other players.
3. There are two Options: Skin Customization->Main Hand: [Right, Left] and VR Settings->Controller Settings->Reverse Hands: [OFF, ON]. The main tool hand should be set in just one place.

Test Conditions:

• Minecraft Java edition 1.18.2
• Minecraft paper 1.18.2 server using Vivecraft_Spigot_Extension.jar posted on on Vivecraft discord 16 March 2022
• Clients are using vivecraft-1.18.2-jrbudda-[VR,NONVR]-2-a3-installer.jar posted 27 March 2022
• First-person player is using original HTC Vive headset and wand controllers
• Third-person observer is using non-VR vivecraft-1.18.2-jrbudda-NONVR-2-a3-installer.jar client, while the first-person player is in VR.
• First-person player is using either the VR or non-VR client (see below)

Test Results:

Skin Customization	VR Settings	1st person VR	1st person non-VR	3rd person
Main Hand: Right	Reverse Hands: OFF	:heavy_check_mark:	:heavy_check_mark:	:heavy_check_mark:
Main Hand: Right	Reverse Hands: ON	:x:	:heavy_check_mark:
Main Hand: Left	Reverse Hands: OFF	:x:	:heavy_check_mark:
Main Hand: Left	Reverse Hands: ON	:x:	:heavy_check_mark:	:x:

What is working correctly:

• The hotbar is oriented correctly on the side of the off-hand arm in VR (at least after menus have been visited at least once)

What is not working correctly:

• When Reverse Hands is ON, the off-hand held shield is located between my arm and my body. This is wrong. So the held-item pose is not correct in this case. This problem is apparent in both the first-person and third-person views.
• When Skin Customization->Main Hand:LEFT is selected, the First and Third person views disagree about which item is held in which hand.
• Vivecraft should respect the main tool hand specified in the Skin Customization options.

There are interesting changes in the arm textures in the various cases, but I have not yet studied carefully enough to decide if any are incorrect.

[Techjar]

Yep.

[Techjar]

This is all going to get restructured at some point, and we'll either completely ignore the vanilla hand setting, or merge the reverse hands setting into it. Having two separate settings is dumb.

[jrbudda]

thanks for the very thorough analysis, this will serve as a useful test matrix for when we tackle this problem