jrbudda / Vivecraft_119

VR mod for Minecraft. For Version 1.19.X http://www.vivecraft.org
Other
49 stars 9 forks source link

install.bat/install.sh: "Invalid class file" #6

Open jcrm1 opened 2 years ago

jcrm1 commented 2 years ago

I can't get install.bat or install.sh to work on Windows or macOS respectively. On both operating systems I get the same errors:

!! need either jad or fernflower available with patches !!

"Resolved" by commenting out the line that exits the code immediately after printing the above error

Decompile failed

Error not very informative- turns out the issue was a missing jadretro.jar. Resolved by downloading and placing in runtime/bin/jadretro.jar.

Error: invalid class file: temp\cls\minecraft\com\mojang\blaze3d\audio\Channel.class

I've got nothing- my only guesses are that either the version of jadretro.jar I'm using is too old or there's not a version of jadretro.jar new enough for this, and it's supposed to use a different decompiler (fernflower?).

I see that the README states these instructions are a little outdated, but that message has stayed the same since the Vivecraft-117 repo. Are there any updated instructions for this? If not, does anyone have advice on how to get this working?

jcrm1 commented 2 years ago

If I set use_ff = True in decompile_side, it instead errors with !! Missing ff patches. Aborting !!. This appears to be caused by FFPatchServer in mcp.cfg referencing a %(DirConf)s/patches/minecraft_server_ff directory that does not exist.

jcrm1 commented 2 years ago

Perhaps unsurprisingly, setting FFPatchServer to the same value as FFPatchClient allows it to continue but then gives the following error:

Patching Optifine merge decompile errors...
patching file net/minecraft/core/Holder.java
patching file net/minecraft/util/datafix/fixes/LeavesFix.java
patching file net/minecraft/util/datafix/fixes/TrappedChestBlockEntityFix.java
patching file net/minecraft/util/thread/BlockableEventLoop.java
Hunk #1 FAILED at 219.
1 out of 1 hunk FAILED -- saving rejects to file net/minecraft/util/thread/BlockableEventLoop.java.rej
patching file net/minecraft/util/valueproviders/ConstantFloat.java
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file net/minecraft/util/valueproviders/ConstantFloat.java.rej
patching file net/minecraft/network/chat/PreviewableCommand.java
patching file net/minecraft/world/ticks/ScheduledTick.java
patching file net/minecraft/world/entity/Mob.java
Hunk #1 FAILED at 1443.
1 out of 1 hunk FAILED -- saving rejects to file net/minecraft/world/entity/Mob.java.rej
patching file net/minecraft/world/level/LevelAccessor.java
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- a/net/minecraft/world/level/chunk/LevelChunkSection$1BlockCounter.java
|+++ b/net/minecraft/world/level/chunk/LevelChunkSection$1BlockCounter.java