search

jrchoo / pe

0 stars 0 forks source link

Able to input 0.00 for pay #10

Open jrchoo opened 9 months ago

jrchoo commented 9 months ago

Not really sure why it is possible to key in 0.00 for pay.

image.png Steps:

  1. pay 7 0.00
nus-se-script commented 9 months ago

Team's Response

Duplicate of #2734 since it's the same bug

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Can pay $0 to someone

Screenshot 2023-11-17 at 4.53.24 PM.png

It may be redundant to be able to pay someone $0.

[original: nus-cs2103-AY2324S1/pe-interim#2172] [original labels: type.FeatureFlaw severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for the bug report! My interpretation of your bug report is that you think it's redundant to be able to record a payment of $0 (either through the pay or owe command), and a possible new enhancement for this bug is that we could add an error or warning message when someone uses pay/owe for $0 stating that no transaction is recorded.

If that's the case, I think that's fair and makes sense as a bugfix to ease user confusion. We agree with your assessment that it is a Feature Flaw since this is not a feature we thought of implementing. We agree with your assessment that it is severity.VeryLow since it is purely cosmetic and does not affect usage -- trying to pay or owe $0 does in fact have the same outcome as implementing the new warning message, which is that the contact's balance changes by 0.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]