jrchoo / pe

0 stars 0 forks source link

Different people are able to have the same email #2

Open jrchoo opened 9 months ago

jrchoo commented 9 months ago

While the app does not allow 2 people to have the same, they are able to have the email as well as other details.

image.png Steps:

  1. add n/John Doe p/98765432 e/johndoe@gmail.com a/John street, block 123, #01-01
  2. add n/John p/987654321 e/johndoe@gmail.com a/John street, block 123, #01-01
nus-se-bot commented 9 months ago

Team's Response

Thank you for raising this issue. If you have carefully read our planned enhancements, we have clearly indicated that in the future iteration, we will be working towards making a person unique in CampusConnect. However, as of now, due to time constraints, we forgo this current problem we noticed.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Even though it has been mentioned in the planned enhancements section, I do not think it wise to place this bug under NotInScope. Checking for duplicates should have been implemented in one of the earlier iterations of the app. It is more likely that 2 people will have the same name, rather than the same email and/or phone number. Instead, the app does the opposite. In fact, 'duplicate' names can be achieved with different whitespacing and upper/lowercase letters, making it difficult to distinguish between 2 distinct entries.