search

jrchoo / pe

0 stars 0 forks source link

Invalid phone numbers #3

Open jrchoo opened 9 months ago

jrchoo commented 9 months ago

Given that CampusConnect is targeted at NUS students living on campus, everyone is likely to have a local phone number. As such, phone numbers that do not follow the 8-digit format should be considered invalid. In the screenshot below, I was able to add numbers of length 9 and 7 respectively.

image.png

Steps:

  1. add n/John p/987654321 e/johndoe@gmail.com a/John street, block 123, #01-01
  2. add n/John p/9876543 e/johndoe@gmail.com a/John street, block 123, #01-01
nus-se-script commented 9 months ago

Team's Response

Thank you for this bug report!

However, we believe that this bug report is based on misguided assumptions.

It is inaccurate to assume that every student will be using a local phone number, given that NUS students comprise of short-term foreign exchange students as well. Restricting the length of phone numbers would be unnecessarily restrictive and would reduce our functionality for these foreign students.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]