jrchoo / pe

0 stars 0 forks source link

Error message not specific for addalt #4

Open jrchoo opened 9 months ago

jrchoo commented 9 months ago

When the index provided is out of bounds, the error message displayed is not very descriptive of the issue. The index keyed in is 10 which is a positive integer.

image.png

Steps:

  1. addalt 10
soc-se-bot commented 9 months ago

Team's Response

Specificity in error message should be classified as feature flaw as per guidelines

Clearly, your current command doesn't follow the strict rules of addalt command, i.e. for it to be considered a valid command, you are required to enter all your inputs first, the PERSON_INDEX alongside with at least 1 of the alternative contact information parameter if you take a closer look at our UG here. According to the logic flow of our program, we ensure that this is satisfied first before we check the validity of arguments inputted by users.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]