search

jrchoo / pe

0 stars 0 forks source link

Notifications are not as expected #9

Open jrchoo opened 9 months ago

jrchoo commented 9 months ago

The app claims to give reminders of birthdays that occur within one day. However, the timing of the notification given is incorrect.

image.png

image.png

nus-se-script commented 9 months ago

Team's Response

Thank you for this bug report! There is no functionality issue in this case as both notifications have an accurate date.

However, the bug we've identified is the screenshot in the user guide which we have yet to update to match the feature. As such, I've edited the severity and bug type to reflect this.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: Although the screenshot in the UG is supposed to be based on the actual app and hence make this a type.DocumentationBug, it makes more sense for someone's birthday to be marked as "2023-10-25 00:00" rather than "2023-11-18 23:59" i.e The screenshot shown in the UG is more logical compared to the output of the actual app. Thus, it should be a type.FunctionalityBug.

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** As I have mentioned previously, it is more natural to mark someone's birthday at 12 midnight (00:00) and not 11.59pm (23:59). This can cause confusion as the difference between "2023-11-18 00:00" and "2023-11-18 23:59" is basically one full day, and may lead to users interpreting the birthday as "2023-11-19 00:00" and cause them to miss their friend's birthday.