jrconlin / WebPushDataTestPage

Web Push Data Encryption Test Page
Mozilla Public License 2.0
15 stars 11 forks source link

feat: Add dash sig verify & sign #18

Closed jrconlin closed 8 years ago

jrconlin commented 8 years ago

Extract vapid errors to dict for future int'l. Create functions to export public key in RAW format; sign a dev dash token and verify a dev dash token.

@groovecoder r?

groovecoder commented 8 years ago

Some nit-picks about variable names, but looks good. Spot-checking locally now ...

groovecoder commented 8 years ago

The code looks good, but it still generates a new signed value every time I click "Sign token", which doesn't make sense to me. If it's signing the same string with the same key each time, shouldn't the output value always be the same?

groovecoder commented 8 years ago

Does the merge mean you were able to successfully validate the generated VAPID key in the dev dashboard?