Specify data types to Dataset.query

coveralls commented 6 years ago

Coverage increased (+0.2%) to 86.081% when pulling 17587b3cdd03d5c1d1e401508e8d2c8ce40245fc on moonso:develop into d72fe491ff316a30452c0ef4d0451590282869b9 on jrderuiter:develop.

moonso commented 6 years ago

Hmm I get the same problem on travis for the older python versions, not sure why..

../../../miniconda/envs/test/lib/python3.4/site-packages/_pytest/python.py:411: in _importtestmodule
    mod = self.fspath.pyimport(ensuresyspath=importmode)
../../../miniconda/envs/test/lib/python3.4/site-packages/py/_path/local.py:668: in pyimport
    __import__(modname)
E     File "/home/travis/build/jrderuiter/pybiomart/tests/test_dataset.py", line 124
E       res = mock_dataset.query(**query_params, dtypes=data_types)
E                                              ^
E   SyntaxError: invalid syntax

moonso commented 5 years ago

@jrderuiter have you abandoned this or can you merge?

jrderuiter commented 5 years ago

Sorry, I totally missed this! Thanks for the PR, your changes look fine 👍

jrderuiter / pybiomart

Specify data types to Dataset.query #5