Closed chil360 closed 7 years ago
Hi, Can you please share more details because both options should be supported :-)
On Apr 21, 2017, at 8:23 PM, chil360 notifications@github.com wrote:
After the changes for Markdown email support, you can no longer set a custom view for the email as it is now hardcoded in the VerificationTokenGenerated class.
Can you add this feature again, please?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Used to be able to set the email view using UserVerification::emailView() but this was removed in the markdowm commit (https://github.com/jrean/laravel-user-verification/commit/d9d3fc51da19da1ab42d1b73d731d25e89fabc00)
The email view name is now hardcoded here: https://github.com/jrean/laravel-user-verification/blob/master/src/Mail/VerificationTokenGenerated.php#L79 Similarly, the markdown view is also hardcoded: https://github.com/jrean/laravel-user-verification/blob/master/src/Mail/VerificationTokenGenerated.php#L77
Ok got it. But, you can both publish and customize the view and the Markdown view. It's not enough?
I'll work on it.
On Apr 21, 2017, at 9:33 PM, chil360 notifications@github.com wrote:
Used to be able to set the email view using UserVerification::emailView() but this was removed in the markdowm commit (d9d3fc5)
The email view name is now hardcoded here: https://github.com/jrean/laravel-user-verification/blob/master/src/Mail/VerificationTokenGenerated.php#L79 Similarly, the markdown view is also hardcoded: https://github.com/jrean/laravel-user-verification/blob/master/src/Mail/VerificationTokenGenerated.php#L77
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
It's not a big issue, just trying to group my views together in a more modular way.
Thanks for looking at this.
https://github.com/jrean/laravel-user-verification/releases/tag/v4.1.8 Can you please test? It should be good now :-)
Tested & working. Thanks!
After the changes for Markdown email support, you can no longer set a custom view for the email as it is now hardcoded in the VerificationTokenGenerated class.
Can you add this feature again, please?