search

jrebecchi / React-Web-Media-Player

A React Player that can play videos, audio tracks, slideshows, with a customizable design.
https://react-web-media-player.herokuapp.com/
MIT License
30 stars 9 forks source link

Center Slideshow Images in Player #11

Closed Azazi closed 2 years ago

Azazi commented 3 years ago

When using the player to display a slideshow, the images are not always centred. This is due to a simple bug in react-web-media-player/lib/components/Medias/Channels/Slideshow.js L173:

var margin = (height - imgHeight / imgWidth * width) / 2;

The lack of parentheses around the height - imgHeight & imgWidth * width calculations results in erroneous calculations for the leftMargin CSS property.

Fixes #12